Some more validation stuff, and a script to check them :) #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Jekyll was optimizing <span class="current-year"></span> to <span class="current-year" /> which is invalid. - Because it was invalid, browsers (and the validator) were treating it as a <span> start tag. Because of this, when the text of the span was set via javascript, some of the copyright info was being lost. So instead of "Copyright (c) 2002-2013 EPFL, Lausanne, unless otherwise specified. \ All rights reserved." We were seeing just: "Copyright (c) 2002-2013"
Member
|
LGTM! Amazing, that tool :) |
Contributor
Author
|
Thanks for being so open to patches, :) Will keep working on this as time permits. |
Member
|
Oh man, thanks a lot for helping us out on this. We really appreciate it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on HTML5 validation. Still some to go. Will keep working on this in my spare time.
https://gist.github.com/CodeBlock/6127856